fix h2 protocol abnormal case when SETTINGS_HEADER_TABLE_SIZE set to zero #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Put it another way because of dynamic table size limitation, HTTP/2.0 uses dynamic tables to store the most recently used request header fields for compression and reuse. If the dynamic table reaches a size limit, the new request Header Field is sent using the Literal Header Field without Indexing encoding to avoid overflows. |
|
https://datatracker.ietf.org/doc/html/rfc7541#section-4.2 about Maximum Table Size |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
when use h2:grpc protocol pass nginx, if nginx not support dynamic HPACK, it will set SETTINGS_HEADER_TABLE_SIZE value to 0，now brpc not address this case.
https://trac.nginx.org/nginx/ticket/1538
rfc reference: https://datatracker.ietf.org/doc/html/rfc9113 4.3.1
Issue Number:
#2286
#2176
Problem Summary:
ignore a h2 protocol param set case
What is changed and the side effects?
Changed:
add a if check when encode h2 header
Side effects:
Performance effects(性能影响):
It hardly makes a difference
Breaking backward compatibility(向后兼容性):
completely compatible
Check List: